Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --strip-components option #735

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Add --strip-components option #735

merged 2 commits into from
Jun 22, 2023

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jun 21, 2023 •
edited
Loading

Add --strip-components option
Delete unnecessary files
Relate adoptium/temurin-build#3245

Signed-off-by: Sophia Guo [email protected]

@sophia-guo
Add --strip-components option
7a8e6dd 
Add --strip-components option
Delete unnecessary files

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo self-assigned this Jun 21, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@sophia-guo
Add comments
a5b5b86 
Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo merged commit 17418f8 into adoptium:master Jun 22, 2023
sxa
sxa reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is a GNU specific option and so will not necessarily be available on all systems.

luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
@sophia-guo @luhenry
Add --strip-components option (adoptium#735)
e352daf 
Add --strip-components option
Delete unnecessary files

Signed-off-by: Sophia Guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa left review comments

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@karianna karianna karianna approved these changes

@smlambert smlambert Awaiting requested review from smlambert

Assignees

@sophia-guo sophia-guo

Labels
None yet
Projects
No open projects
Adoptium 2Q 2023 Plan
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sophia-guo @karianna @sxa @andrew-m-leonard